Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bundler): gracefully ignore internal packages #32923

Merged

Conversation

Djiit
Copy link
Contributor

@Djiit Djiit commented Dec 5, 2024

Changes

With this change, Renovate will now consider gems declared with a path to be local and skip them with reason internal-package.

Relates to #32749

Context

Bundler support was missing this part and the skip reason was not correct.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@Djiit Djiit force-pushed the feat-bundler-ignore-internalpackages branch from cc0789e to ad51249 Compare December 5, 2024 15:36
@Djiit Djiit force-pushed the feat-bundler-ignore-internalpackages branch from ad51249 to 8431949 Compare December 5, 2024 15:40
@Djiit Djiit marked this pull request as ready for review December 5, 2024 15:44
@rarkins rarkins added this pull request to the merge queue Dec 5, 2024
Merged via the queue into renovatebot:main with commit fd31844 Dec 5, 2024
56 checks passed
SuperSandro2000 added a commit to SuperSandro2000/renovate that referenced this pull request Dec 5, 2024
* upstream/main: (95 commits)
  fix(presets): use regex to match versions for :automergeStableNonMajor preset (renovatebot#32924)
  feat(bazel-module): add support for oci.pull (renovatebot#32453)
  fix(deps): update ghcr.io/containerbase/sidecar docker tag to v13.1.0 (renovatebot#32925)
  fix(bundler): gracefully ignore internal packages (renovatebot#32923)
  docs: list uv.lock as supported by lockFileMaintenance. (renovatebot#32897)
  chore(deps): update ghcr.io/containerbase/devcontainer docker tag to v13.1.0 (renovatebot#32920)
  refactor(bundler): refactor extraction regexes (renovatebot#32870)
  chore(deps): update dependency @types/node to v20.17.9 (renovatebot#32916)
  chore(deps): update python:3.13 docker digest to 220d075 (renovatebot#32914)
  chore(deps): update python:3.13 docker digest to 30fca17 (renovatebot#32912)
  chore(deps): update python docker tag to v3.13.1 (renovatebot#32913)
  fix(docs): typos (renovatebot#32888)
  chore(deps): update otel/opentelemetry-collector-contrib docker tag to v0.115.1 (renovatebot#32911)
  fix(deps): update ghcr.io/renovatebot/base-image docker tag to v9.14.1 (renovatebot#32910)
  fix(metadata): update changelog URL for mypy (renovatebot#32106)
  chore(deps): update dependency type-fest to v4.29.0 (renovatebot#32902)
  chore(deps): update python:3.13 docker digest to e95be02 (renovatebot#32900)
  docs(faq): mention weekly update goal for Mend Renovate app (renovatebot#32899)
  feat(deps): update ghcr.io/renovatebot/base-image docker tag to v9.14.0 (renovatebot#32896)
  chore(deps): update python:3.13 docker digest to 7861d60 (renovatebot#32895)
  ...
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.50.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants