Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datasource/maven): Introduce option to assume that looked up maven data is specification compliant #32651

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AB-xdev
Copy link

@AB-xdev AB-xdev commented Nov 21, 2024

Changes

The current maven datasource lookup is not conform with the Maven standards and was only introduced because a few people used misconfigured maven repositories.

This PR introduces an experimental option RENOVATE_X_MAVEN_LOOKUP_ASSUME_SPECIFICATION_COMPLIANT.
If this is set, Renovate assumes that the looked up Maven Metadata conforms to specification and will skip some checks and requests.

Context

Fixes #27768

In the future it might be desirable to make this the default.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins
Copy link
Collaborator

rarkins commented Dec 5, 2024

@zharinov is this partially redundant after your html changes?

@zharinov
Copy link
Collaborator

zharinov commented Dec 5, 2024

Oh yes, my final goal is to eliminate the need for option like this

@AB-xdev
Copy link
Author

AB-xdev commented Dec 6, 2024

What changes are you talking about?

@viceice viceice changed the title Introduce option to assume that looked up maven data is specification compliant feat(datasource/maven): Introduce option to assume that looked up maven data is specification compliant Dec 9, 2024
@philippe-granet
Copy link

What changes are you talking about?

#32662

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants