Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(presets): add poetry manager support to :semanticPrefixFixDepsChoreOthers preset #32246

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

sisp
Copy link
Contributor

@sisp sisp commented Oct 31, 2024

Changes

I've added a package rule to the :semanticPrefixFixDepsChoreOthers preset that sets the semantic commit type fix for Poetry runtime dependencies (particularly, optional dependencies aka "extras"). I decided to add a new package rule with

matchDepTypes: ['dependencies, 'extras']

to the preset, although the second package rule in the preset already generically matches the depType: 'dependencies', to have a self-contained package rule for Poetry. Alternatively, I could have added the 'extras' to the matchDepTypes array of the second package rule

-matchDepTypes: ['dependencies', 'require'],
+matchDepTypes: ['dependencies', 'require', 'extras'],

but I felt that Poetry's depType: 'extras' is too specific to be added to this generic rule. Please feel free to prefer the alternative over the current implementation if you disagree with me.

Context

I noticed that PRs updating optional dependencies while using the preset :semanticPrefixFixDepsChoreOthers used the commit type chore and not fix since #32096 had been merged. Before #32095, optional dependencies were assigned an incorrect depType value ('dependencies' instead of 'extras'). Prior to this PR, the preset :semanticPrefixFixDepsChoreOthers didn't include a package rule with matchDepTypes containing the value 'extras'.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Snapshots were updated and look correct.

@rarkins rarkins added this pull request to the merge queue Nov 1, 2024
Merged via the queue into renovatebot:main with commit 1810672 Nov 1, 2024
39 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 38.142.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sisp sisp deleted the feat/chore-fix-preset-poetry branch November 1, 2024 06:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants