feat(presets): add poetry
manager support to :semanticPrefixFixDepsChoreOthers
preset
#32246
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I've added a package rule to the
:semanticPrefixFixDepsChoreOthers
preset that sets the semantic commit typefix
for Poetry runtime dependencies (particularly, optional dependencies aka "extras"). I decided to add a new package rule withto the preset, although the second package rule in the preset already generically matches the
depType: 'dependencies'
, to have a self-contained package rule for Poetry. Alternatively, I could have added the'extras'
to thematchDepTypes
array of the second package rulebut I felt that Poetry's
depType: 'extras'
is too specific to be added to this generic rule. Please feel free to prefer the alternative over the current implementation if you disagree with me.Context
I noticed that PRs updating optional dependencies while using the preset
:semanticPrefixFixDepsChoreOthers
used the commit typechore
and notfix
since #32096 had been merged. Before #32095, optional dependencies were assigned an incorrectdepType
value ('dependencies'
instead of'extras'
). Prior to this PR, the preset:semanticPrefixFixDepsChoreOthers
didn't include a package rule withmatchDepTypes
containing the value'extras'
.Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
Snapshots were updated and look correct.