Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dashboard): move header to top #32160

Merged
merged 1 commit into from
Oct 28, 2024
Merged

fix(dashboard): move header to top #32160

merged 1 commit into from
Oct 28, 2024

Conversation

tasneemkoushar
Copy link
Contributor

@tasneemkoushar tasneemkoushar commented Oct 27, 2024 •
edited by rarkins
Loading

Changes

Refactored code to bring Dependency Dashboard header on top

Context

Closes #32104

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@CLAassistant
Copy link

CLAassistant commented Oct 27, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@tasneemkoushar tasneemkoushar changed the title refactored code to bring Dependency Dashboard header on top fix: refactored code to bring Dependency Dashboard header on top Oct 27, 2024
@tasneemkoushar tasneemkoushar changed the title fix: refactored code to bring Dependency Dashboard header on top fix: refactored code Oct 27, 2024
@rarkins rarkins enabled auto-merge October 27, 2024 07:14
@rarkins rarkins disabled auto-merge October 27, 2024 07:15
@viceice viceice changed the title fix: refactored code fix(dashboard): move header to top Oct 27, 2024
HonkingGoose
HonkingGoose suggested changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to link to the issue this PR closes, before we merge it?

lib/workers/repository/dependency-dashboard.ts Show resolved Hide resolved
@rarkins rarkins requested a review from HonkingGoose October 28, 2024 09:54
HonkingGoose
HonkingGoose approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR now properly closes the related issue when it gets merged. I'll let the maintainers review the code.

@rarkins rarkins added this pull request to the merge queue Oct 28, 2024
Merged via the queue into renovatebot:main with commit ed8c6f5 Oct 28, 2024
39 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 38.133.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RahulGautamSingh RahulGautamSingh RahulGautamSingh approved these changes

@HonkingGoose HonkingGoose HonkingGoose approved these changes

@rarkins rarkins rarkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dependency Dashboard header no longer always on top
6 participants
@tasneemkoushar @CLAassistant @renovate-release @rarkins @HonkingGoose @RahulGautamSingh