-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashboard): on demand config migration #31129
feat(dashboard): on demand config migration #31129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs docs. Potentially even a new page to discuss config migration in general which can then be linked from the configMigration
docs entry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also try to use a consistent term in logging so that you can Ctrl-F to search for all applicable messages. e.g. configMigration:
or "Config migration" in each message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of suggested changes, to summarize:
- Add headings
- Rewrite to focus on the reader
- Explain a bit more about why we want/need config migration
- Rewrite the user-facing texts from Renovate about config migration (dashboard text, PR link text, etc.)
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be merged after manual testing from @zharinov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It worked on my test repo
🎉 This PR is included in version 38.126.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Changes
Context
Closes: #19783
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
Test Runs
Config Migration: false: checkbox-added, migration pr linked in dd, checkbox-added-when-closed-pr-found, migration-pr-linked (closed-pr-exists)
Config Migration true: pr created & linked no checkbox needed, checkbox-added-if-closed-pr-found, pr-linked-again-after-checkbox-checked (closed-pr-exists)
Modified Migration PR