Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(worker/global): apply allowedHeaders again #29281

Merged
merged 1 commit into from
May 27, 2024
Merged

Conversation

viceice
Copy link
Member

@viceice viceice commented May 27, 2024

Changes

Found while reviewing #29154. allowedHeaders is not available when loading remote presets.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice requested review from rarkins and secustor May 27, 2024 12:52
@rarkins
Copy link
Collaborator

rarkins commented May 27, 2024

Additional problem to what was fixed in #28228 ?

@viceice
Copy link
Member Author

viceice commented May 27, 2024

Additional problem to what was fixed in #28228 ?

yes, this set will override the set some lines above.

@rarkins rarkins added this pull request to the merge queue May 27, 2024
Merged via the queue into main with commit 842f205 May 27, 2024
37 checks passed
@rarkins rarkins deleted the fix/global-config branch May 27, 2024 14:04
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.379.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants