Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(gomod): Simplify dependency extraction #28852

Merged
merged 3 commits into from
May 6, 2024
Merged

refactor(gomod): Simplify dependency extraction #28852

merged 3 commits into from
May 6, 2024

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented May 5, 2024

Changes

  • Parse line-by-line
  • Eliminate the need for state between the lines

This PR will simplifies the detection of extra modules modified by go get during artifact update phase.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov changed the title refactor(gomod): Simplify dependency extraction implementation refactor(gomod): Simplify dependency extraction May 5, 2024
@zharinov zharinov requested review from viceice and rarkins May 5, 2024 23:23
viceice
viceice reviewed May 6, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move extract.spec.ts refactorings to seperate PR

lib/modules/manager/gomod/extract.spec.ts Show resolved Hide resolved
rarkins
rarkins approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if our tests are good :)

viceice
viceice approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not using the good enough parser?

@zharinov
Copy link
Collaborator Author

zharinov commented May 6, 2024

why not using the good enough parser?

I think it will be more complex than this one, as it requires tokenizer setup and then if-then checks anyway

@rarkins rarkins added this pull request to the merge queue May 6, 2024
Merged via the queue into renovatebot:main with commit 5aa2ebf May 6, 2024
37 checks passed
@rarkins rarkins deleted the refactor/27775-gomod-simpler-extract branch May 6, 2024 17:23
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.346.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins approved these changes

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zharinov @renovate-release @viceice @rarkins