Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(npm): support pnpm v9 #28470

Merged
merged 2 commits into from
Apr 17, 2024
Merged

feat(npm): support pnpm v9 #28470

merged 2 commits into from
Apr 17, 2024

Conversation

viceice
Copy link
Member

@viceice viceice commented Apr 17, 2024

Changes

  • fix: don't delete lockfile in writeExistingFiles, they will be deleted generateLockFile
  • fix: from v6 the lockfile version is string
  • feat: add lockfile v9 support

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice requested review from rarkins and secustor April 17, 2024 09:24
HonkingGoose
HonkingGoose reviewed Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comment comments. 🙃

lib/modules/manager/npm/post-update/pnpm.ts Outdated Show resolved Hide resolved
lib/modules/manager/npm/post-update/pnpm.ts Outdated Show resolved Hide resolved
lib/modules/manager/npm/post-update/pnpm.ts Outdated Show resolved Hide resolved
lib/modules/manager/npm/post-update/pnpm.ts Outdated Show resolved Hide resolved
lib/modules/manager/npm/post-update/pnpm.ts Outdated Show resolved Hide resolved
@viceice viceice mentioned this pull request Apr 17, 2024
Merged
6 tasks
@viceice viceice requested review from HonkingGoose and rarkins April 17, 2024 09:56
HonkingGoose
HonkingGoose approved these changes Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the comments. I'll leave the code review to others.

@viceice viceice added this pull request to the merge queue Apr 17, 2024
Merged via the queue into main with commit b652e85 Apr 17, 2024
37 checks passed
@viceice viceice deleted the feat/npm/pnpm-v9 branch April 17, 2024 10:54
@RobHannay
Copy link
Contributor

You're amazing. Thanks!

@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.303.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@vluoto vluoto mentioned this pull request Apr 18, 2024
Closed
1 task
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HonkingGoose HonkingGoose HonkingGoose approved these changes

@secustor secustor secustor approved these changes

@rarkins rarkins Awaiting requested review from rarkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support pnpm v9 lockfiles
6 participants
@viceice @RobHannay @renovate-release @rarkins @secustor @HonkingGoose