Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cache): Fix compression and decompression format mismatch #27021

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Feb 2, 2024

Changes

This PR should prevent from throwing at JSON.parse() which most probably caused constant cache miss condition.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins
Copy link
Collaborator

rarkins commented Feb 2, 2024

@onigoetz wdyt?

Copy link
Contributor

@onigoetz onigoetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, compression and decompression are symmetrical again.

@rarkins rarkins added this pull request to the merge queue Feb 2, 2024
Merged via the queue into renovatebot:main with commit 68d5faa Feb 2, 2024
36 checks passed
@rarkins rarkins deleted the fix/redis-compression-perf branch February 2, 2024 16:33
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.168.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants