fix(platform/azure): Allows azure-got-wrapper to retry requests following connection failures #24348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccopsey
changed the title
rarkins
previously approved these changes
Sep 11, 2023
viceice
requested changes
Sep 11, 2023
auto-merge was automatically disabled
September 11, 2023 15:50
Head branch was pushed to by a user without write access
viceice
approved these changes
Sep 11, 2023
|
🎉 This PR is included in version 36.93.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
For posterity:10 days since this was merged and I haven't suffered any ECONNRESET failures since. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Allows
azure-got-wrapperto retry requests in the event of a connection failure. A maximum of 2 retries is defined, giving a maximum of 3 requests in total.Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
I run renovate via docker in production. For the last 4 days I have run a manually updated docker image with the above change applied. It is impossible to say that the this change works as it is a very flakey failure mode, but I can say that I haven't seen any errors and that this change hasn't caused new issues within renovate.