Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Revert "feat(manager/poetry): extract python as a dependency from pyproject.toml" #24257

Merged
merged 1 commit into from
Sep 6, 2023
Merged

fix: Revert "feat(manager/poetry): extract python as a dependency from pyproject.toml" #24257

merged 1 commit into from
Sep 6, 2023

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Sep 5, 2023

Reverts #24236

viceice
viceice approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in future this should be split to two PR, one for extract and one for artifacts

@zeshuaro
Copy link
Contributor

zeshuaro commented Sep 5, 2023 •
edited
Loading

in future this should be split to two PR, one for extract and one for artifacts

The changes had to be made together because if python is extracted and updated from pyproject.toml, and artifact doesn’t use the updated version, it might fail to update the artifacts. Because it might be using the wrong/disallowed version of python from pyproject.toml.

@rarkins rarkins added this pull request to the merge queue Sep 6, 2023
Merged via the queue into main with commit 185f124 Sep 6, 2023
@rarkins rarkins deleted the revert-24236-feat/poetry-extract-python branch September 6, 2023 04:39
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.83.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rarkins @zeshuaro @renovate-release @viceice