-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(manager/composer): Use bitbucket-tags for vcs repos if it has bitbucket.org URL #24096
feat(manager/composer): Use bitbucket-tags for vcs repos if it has bitbucket.org URL #24096
Conversation
Co-authored-by: Rhys Arkins <[email protected]>
Co-authored-by: Rhys Arkins <[email protected]>
Sorry for asking this question. Do I understand that right, that the PR gets merged as soon as it has tests that cover the new feature? If so, I will try my best to contribute some. But I never worked with jest before. Perhaps anyone can guide me how I can check the coverage locally without running all the tests. |
Yes, it's set to automerge once tests pass, and that requires 100% unit test coverage |
Head branch was pushed to by a user without write access
I have added a test, that should cover the change. Unfortunately, my commits disabled the auto-merge, so I cannot see if it really fixed the coverage. As far as I can see locally, it should. At least it was on 100% when I ran |
@rarkins Looks like Github had an issue what failed the Action. Can you requeue for merge? Thank you! |
🎉 This PR is included in version 36.87.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
Currently, all "vcs" repositories (repositories added via git URL instead of using a provider like packagist) use
git-tags
. Unfortunately, this is not working with Bitbucket and result in authentication issues.This PR adds a regex-based check if it is a Bitbucket URL and declares to use the
bitbucket-tags
datasource. If it is not, the current behavior stays unchanged.The credentials (if needed) are used from
username
andpassword
ifplatform
is set to "bitbucket". Otherwise, you can usehostRules
to set the credentials f.e. as followed:Context
renovate/lib/modules/manager/flux/extract.ts
Lines 136 to 142 in 151435a
Closes #24065.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
I have also tried with invalid credentials, and it failed as expected (to prove
hostRules
have an actual effect).Note: This is my first PR at renovate, and I never worked with TypeScript before. So I am open for any suggestions or contributions to make this PR ready to merge if it is not already.