-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(datasource/docker): Add support for Google Application Default Credentials #23903
Conversation
Thanks!
@viceice the code coverage (of course) fails. I don't know how much sense it makes to test my current changes but I can look into writing a test for it if desired. Let me know what you would like me to do! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please run on a real repo
@viceice I ran it against a real repository and found out that I made a mistake. With the change I made the onboarding PR showed the expected PRs that it would create. Thus proofing (to me) that it works with Google Application Default Credentials, since I didn't set any authorization configs for Artifact Registry. |
@viceice Could you please re-review? |
Needs deconflicting |
@rarkins done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still broken pnpm lockfile
@viceice Sorry about that, the pnpm lock file rebroke after I fixed it in my earlier commit. It's working now again and I also applied your PR feedback (should've checked it after applying my fixes). Thanks for taking the time to review my PR! |
@viceice is there something I need to change or can this feature be merged? Thank you for your time! |
@kvanzuijlen it's best that you don't merge from main any more because that resets the tests to require approval again |
Co-authored-by: Michael Kriese <[email protected]>
Head branch was pushed to by a user without write access
@viceice I hadn't run prettier after the last PR suggestions, sorry about that. |
🎉 This PR is included in version 36.102.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
This PR adds support for Google Application Default Credentials, which also includes GKE Workload Identity. The benefit of using this is that you don't need a service account key (long-lived token) and is a well documented/best practice solution that doesn't need extra custom work on the end user side.
Context
As said in the section above, this PR alleviates the need for a long lived token and instead introduces an option to configure a well documented solution.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
I'll run these changes on a real repository shortly!