Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datasource/packagist): Use serializable type for availablePackages #23117

Merged
merged 2 commits into from
Jul 3, 2023
Merged

fix(datasource/packagist): Use serializable type for availablePackages #23117

merged 2 commits into from
Jul 3, 2023

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Jul 3, 2023 •
edited
Loading

Changes

Using Set was bad idea, since it doesn't play well with serialization, so at some point we'll have non-nullish value, but not the Set itself.
Therefore, object doesn't have "has" method error will be thrown.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov requested review from viceice and rarkins July 3, 2023 17:23
viceice
viceice approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the tests didn't catched that error?

@viceice viceice changed the title fix(packagist): Use serializable type for availablePackages fix(datasource/packagist): Use serializable type for availablePackages Jul 3, 2023
@viceice viceice added this pull request to the merge queue Jul 3, 2023
@zharinov
Copy link
Collaborator Author

zharinov commented Jul 3, 2023

Because tests don't use caching

Merged via the queue into renovatebot:main with commit 1f3a14a Jul 3, 2023
@viceice viceice deleted the fix/packagist-available-package-transform branch July 3, 2023 18:11
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.159.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot mentioned this pull request Jul 9, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@rarkins rarkins Awaiting requested review from rarkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zharinov @renovate-release @viceice