-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fs): permit square brackets []
in file paths
#21625
fix(fs): permit square brackets []
in file paths
#21625
Conversation
@RobHannay Thanks for providing this change! This will fix multiple issues in our installation of Renovate. Can you please sign Renovate CLA so that PR can be merged soon? It's a mandatory requirement explained in contributing.md#legal. |
Hey @chopeen :) I have signed it, so I'm not sure how to get the check to pass? 🤔 |
Thanks @RobHannay! I guess we need to wait for the CI or the maintainers to sort it out then. |
Updating with |
🎉 This PR is included in version 35.57.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Co-authored-by: Sebastian Poxhofer <[email protected]>
Changes
Allows square brackets
[]
in file paths, as they are used heavily in Next.js projects. See minimal repro on the issue.Those characters are also not forbidden in the referenced article:
https://www.mtu.edu/umc/services/websites/writing/characters-avoid/
Context
isValidLocalPath
function #21433[]
#21624@
inside paths #21476Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: