Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fs): permit square brackets [] in file paths #21625

Merged

Conversation

RobHannay
Copy link
Contributor

Changes

Allows square brackets [] in file paths, as they are used heavily in Next.js projects. See minimal repro on the issue.

Those characters are also not forbidden in the referenced article:

https://www.mtu.edu/umc/services/websites/writing/characters-avoid/

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from viceice April 20, 2023 09:47
@viceice viceice enabled auto-merge April 20, 2023 09:59
@viceice viceice added this pull request to the merge queue Apr 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 20, 2023
@chopeen
Copy link
Contributor

chopeen commented Apr 21, 2023

@RobHannay Thanks for providing this change! This will fix multiple issues in our installation of Renovate.

Can you please sign Renovate CLA so that PR can be merged soon? It's a mandatory requirement explained in contributing.md#legal.

@RobHannay
Copy link
Contributor Author

@RobHannay Thanks for providing this change! This will fix multiple issues in our installation of Renovate.

Can you please sign Renovate CLA so that PR can be merged soon? It's a mandatory requirement explained in contributing.md#legal.

Hey @chopeen :) I have signed it, so I'm not sure how to get the check to pass? 🤔

@chopeen
Copy link
Contributor

chopeen commented Apr 21, 2023

Thanks @RobHannay! I guess we need to wait for the CI or the maintainers to sort it out then.

@RobHannay
Copy link
Contributor Author

Thanks @RobHannay! I guess we need to wait for the CI or the maintainers to sort it out then.

Updating with main seemed to kick it into shape 😅

@rarkins rarkins enabled auto-merge April 21, 2023 15:29
@rarkins rarkins added this pull request to the merge queue Apr 21, 2023
Merged via the queue into renovatebot:main with commit b853af2 Apr 21, 2023
@RobHannay RobHannay deleted the fix/fs-util/permit-square-brackets branch April 21, 2023 16:50
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.57.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

mjunker pushed a commit to mjunker/renovate that referenced this pull request May 17, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File paths rejected as invalid when using []
6 participants