feat(github-actions): Change behavior to not add "renovate" to inline yaml comments when pinning #14110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
When Renovate pins docker hashes for github actions it adds an inline comment to the lines to specify which version of the action this hash refers to.
Currently the lines will look like this:
- uses: actions/checkout@ec3a7ce113134d7a93b817d10a8272cb61118579 # renovate: tag=v2.4.0
after this change, any newly written lines will look like this:
- uses: actions/checkout@ec3a7ce113134d7a93b817d10a8272cb61118579 # tag=v2.4.0
Existing lines will not be changed, but still be correctly parsed and written in the new format when they are next updated.
I have also slightly changed the Regex used to parse these strings to be more generous with extra whitespaces. In its current form the regex would tolerate extra whitespaces before the comment, but it seems like this is more or less accidental as they would be added to the currentValue capture group (and then probably stripped or trimmed somewhere, but why take the risk?).
Context:
Closes #14105
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: