Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(secrets): fix host-rules in repo config #10459

Merged
merged 4 commits into from
Jun 16, 2021
Merged

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Jun 16, 2021

Changes:

Fixes use case of bot-configured secrets + repo-configured hostRules.

Context:

Closes #10458

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from viceice June 16, 2021 08:58
@rarkins rarkins enabled auto-merge (squash) June 16, 2021 13:54
@rarkins rarkins merged commit 9184207 into main Jun 16, 2021
@rarkins rarkins deleted the fix/10458-host-rules-secrets branch June 16, 2021 14:02
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 25.43.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Having trouble resolving secrets (config.js --> hostRules)
3 participants