Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(maven): Remove unnecessary HTML page fetches #32662

Merged

Conversation

zharinov
Copy link
Collaborator

Changes

It doesn't seem necessary now when we're able to obtain all necessary information by querying the corresponding POM file of a particular package version.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov requested review from rarkins and viceice and removed request for rarkins November 21, 2024 18:57
@zharinov
Copy link
Collaborator Author

Currently, for every package we're fetching:

  • maven-metadata.xml
  • GET the latest POM file (for homepage/sourceUrl)
  • HEAD the POM file of the selected/filtered release (often matches with GET of the latest one)
  • [Maven Central only] HTML index page

If first 3 are done correctly, seems like we don't need the latter one.

@rarkins rarkins requested a review from Churro November 22, 2024 12:29
Copy link
Collaborator

@Churro Churro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, for every package we're fetching:

* `maven-metadata.xml`
* GET the latest POM file (for `homepage`/`sourceUrl`)
* HEAD the POM file of the selected/filtered release (often matches with GET of the latest one)
* [Maven Central only] HTML index page

If first 3 are done correctly, seems like we don't need the latter one.

If I'm not mistaken "GET the latest POM file (for homepage/sourceUrl)" is done after populating the list of releases, i.e.., any release that is unknown at this point won't be pulled. Hence, the "[Maven Central only] HTML index page" step is actually second, not last. Do you agree?

lib/modules/datasource/maven/index.ts Show resolved Hide resolved
@zharinov zharinov requested a review from rarkins November 24, 2024 13:17
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

@rarkins rarkins requested review from viceice and Churro November 28, 2024 06:12
@rarkins rarkins enabled auto-merge November 28, 2024 10:08
@rarkins rarkins added this pull request to the merge queue Nov 28, 2024
Merged via the queue into renovatebot:main with commit 933ffc8 Nov 28, 2024
39 checks passed
@rarkins rarkins deleted the feat/maven-datasource-remove-html-page-fetch branch November 28, 2024 10:18
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.35.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants