Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: overide punycode built-in module #32502

Merged
merged 2 commits into from
Nov 13, 2024
Merged

fix: overide punycode built-in module #32502

merged 2 commits into from
Nov 13, 2024

Conversation

viceice
Copy link
Member

@viceice viceice commented Nov 13, 2024

Changes

Fixes the deprecation warning.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice added this pull request to the merge queue Nov 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 13, 2024
@viceice viceice added this pull request to the merge queue Nov 13, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 13, 2024
@viceice viceice added the ci:fulltest Run full test suite on all platforms label Nov 13, 2024
@viceice viceice added this pull request to the merge queue Nov 13, 2024
Merged via the queue into main with commit 41ba7c3 Nov 13, 2024
52 checks passed
@viceice viceice deleted the fix/punycode branch November 13, 2024 15:05
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci:fulltest Run full test suite on all platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants