Node Deprecation Warning in v39: The punycode Module is Deprecated

[Gabriel-Ladzaretti]

Describe the proposed change(s).

Since we switched to v39, we can see the following message in the stderr for each renovate job.

(node:925) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
it doesnt seems to affect anything tho. jobs are being completed successfully.

DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
    at node:punycode:3:9
    at BuiltinModule.compileForInternalLoader (node:internal/bootstrap/realm:399:7)
    at BuiltinModule.compileForPublicLoader (node:internal/bootstrap/realm:338:10)
    at loadBuiltinModule (node:internal/modules/helpers:114:7)
    at Function._load (node:internal/modules/cjs/loader:1100:17)
    at TracingChannel.traceSync (node:diagnostics_channel:315:14)
    at wrapModuleLoad (node:internal/modules/cjs/loader:218:24)
    at Module.require (node:internal/modules/cjs/loader:1340:12)
    at require (node:internal/modules/helpers:141:16)
    at Object.<anonymous> (/home/kriese/src/renovate/node_modules/.pnpm/[email protected]/node_modules/whatwg-url/lib/url-state-machine.js:2:18)
    at Module._compile (node:internal/modules/cjs/loader:1546:14)
    at node:internal/modules/cjs/loader:1689:10
    at Object.require.extensions.<computed> [as .js] (/home/kriese/src/renovate/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected][email protected]/node_modules/ts-node/src/index.ts:1608:43)
    at Module.load (node:internal/modules/cjs/loader:1318:32)
    at Function._load (node:internal/modules/cjs/loader:1128:12)
    at TracingChannel.traceSync (node:diagnostics_channel:315:14)
    at wrapModuleLoad (node:internal/modules/cjs/loader:218:24)
    at Module.require (node:internal/modules/cjs/loader:1340:12)
    at require (node:internal/modules/helpers:141:16)
    at Object.<anonymous> (/home/kriese/src/renovate/node_modules/.pnpm/[email protected]/node_modules/whatwg-url/lib/URL-impl.js:2:13)

[bakito]

In my productive setup I've added the following environment variable to prevent this output. The wanings caused issues when parsing the json logs from renovate.

NODE_OPTIONS="--no-deprecation"

[viceice]

> pnpm why whatwg-url
Legend: production dependency, optional only, dev only

[email protected] /home/kriese/src/renovate

dependencies:
@renovatebot/osv-offline 1.5.10
└─┬ node-fetch 2.7.0
  └── whatwg-url 5.0.0
google-auth-library 9.14.2
├─┬ gaxios 6.7.1
│ └─┬ node-fetch 2.7.0
│   └── whatwg-url 5.0.0
├─┬ gcp-metadata 6.1.0
│ └─┬ gaxios 6.7.1
│   └─┬ node-fetch 2.7.0
│     └── whatwg-url 5.0.0
└─┬ gtoken 7.1.0
  └─┬ gaxios 6.7.1
    └─┬ node-fetch 2.7.0
      └── whatwg-url 5.0.0

[viceice]

• Faulty NPM upload 2.7.0 node-fetch/node-fetch#1797 it's fixed in v3 which is esm only 😞

will add an override, so it's at least fixed in our official docker images

[viceice]

• https://github.com/Qix-/node-backslash/pull/4

> pnpm why backslash
Legend: production dependency, optional only, dev only

[email protected] /home/kriese/src/renovate

dependencies:
json-dup-key-validator 1.0.3
└── backslash 0.2.0

[viceice]

• fix: overide punycode built-in module #32502

[viceice]

Leaving this open to remember to remove the workaround when upstream packages are fixed