Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/maven): provide warning log if pom contains windows line ending #31858

Merged
merged 5 commits into from
Oct 15, 2024

Conversation

sebtiem
Copy link
Contributor

@sebtiem sebtiem commented Oct 8, 2024

Changes

As discussed in 19090, I added a warning log message if windows line endings are present when extracting the contents of a maven pom.xml.

Context

See discussion 19090.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • [] Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@CLAassistant
Copy link

CLAassistant commented Oct 8, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ rarkins
❌ Sebastian Panse


Sebastian Panse seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@rarkins rarkins added this pull request to the merge queue Oct 15, 2024
Merged via the queue into renovatebot:main with commit fbc3ba8 Oct 15, 2024
37 of 38 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 38.124.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants