Bot updates Maven property incorrectly <org.slf4j.version>2.0.3</org.slf4j.vers2.0.4

[robsmorenburg]

The renovate bot has updated the below property to:

<org.slf4j.version>2.0.3</org.slf4j.vers2.0.4

It should read:

<org.slf4j.version>2.0.4</org.slf4j.version>

[github-actions[bot]]

Hi there,

Get your issue fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this.

To get started, please read our guide on creating a minimal reproduction.

We may close the issue if you, or someone else, haven't created a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment.

Good luck,

The Renovate team

[bpodlejski]

Reproduction

I have the same issue with pom.xml files in java/maven repositories.
pom.xml file (took from: pom.xml ) :
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"> <modelVersion>4.0.0</modelVersion> <groupId>com.browserstack</groupId> <artifactId>app-testing-examples</artifactId> <packaging>jar</packaging> <version>1.0-SNAPSHOT</version> <name>app-testing-examples</name> <url>http://maven.apache.org</url> <dependencies> <!--<dependency> <groupId>junit</groupId> <artifactId>junit</artifactId> <version>4.11</version> <scope>test</scope> </dependency>--> <dependency> <groupId>org.seleniumhq.selenium</groupId> <artifactId>selenium-java</artifactId> <version>2.50.0</version> </dependency> <dependency> <groupId>org.seleniumhq.selenium</groupId> <artifactId>selenium-server</artifactId> <version>2.53.0</version> </dependency> <dependency> <groupId>io.appium</groupId> <artifactId>java-client</artifactId> <version>4.0.0</version> </dependency> </dependencies> <build> <plugins> <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-compiler-plugin</artifactId> <version>2.3.2</version> <configuration> <source>1.6</source> <target>1.6</target> </configuration> </plugin> <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-surefire-plugin</artifactId> <version>2.4.2</version> </plugin> </plugins> </build> </project>
aslo in repo .gitatributes:
`

•   text=auto
  

•   text eol=crlf
  

*.jpg -text
*.png -text
`

pom.xml after renovate:

Description of PR:

the config.js is:
module.exports = { platform: 'azure', endpoint: 'https://dev.azure.com/ORG_NAME/', extends: ['group:all'], requireConfig: "optional", onboarding: false, token: process.env.TOKEN, hostRules: [ { hostType: 'npm', matchHost: 'pkgs.dev.azure.com', username: 'apikey', password: process.env.TOKEN, }, { "matchHost": "github.com", "token": process.env.GH_TOKEN } ], repositories: [ "##repo##" ], };

in Azure DevOps pipeline (I use pool based on image ubuntu-latest) :
- script: npm i renovate displayName: Install Renovate - bash: | git config --global user.email '[email protected]' git config --global user.name 'Renovate Bot' npx --userconfig .npmrc renovate displayName: Renovate env: GH_TOKEN: $(GH_PAT) RENOVATE_CONFIG_FILE: $(Build.SourcesDirectory)/src/config.js TOKEN: $(System.AccessToken) RENOVATE_LOG_FILE_LEVEL: "debug"

renovate logs:
INFO: Repository started (repository=PROJECT/test.maven) "renovateVersion": "35.20.0" INFO: Dependency extraction complete (repository=PROJECT/test.maven, baseBranch=develop) "stats": { "managers": {"maven": {"fileCount": 1, "depCount": 5}}, "total": {"fileCount": 1, "depCount": 5} } INFO: Branch updated (repository=PROJECT/test.maven, branch=renovate/all) "commitSha": "ad10fad72aa5858ab26ca23b369a112f7efe22f1" INFO: PR created (repository=PROJECT/test.maven, branch=renovate/all) "pr": 112294, "prTitle": "Update all dependencies" INFO: Repository finished (repository=PROJECT/test.maven) "cloned": true, "durationMs": 8762

I don't use in repository file renovate.json

Workaround:

change in .gitatributes (CRLF --> LF):
`

•   text=auto
  

•   text eol=lf
  

*.jpg -text
*.png -text
`

Results:

Proper pon.xml upgrade:

Workaround is easy, but in our case the development is on windows machines and developers don't want to change CRLF --> LF to have easier work for them.
Is there any possible solution to solve that issue (we have 30 repositories affected by this)?

[viceice]

no, renovate currently doesn't support crlf in that case, sorry

[sebtiem]

I had a similar issue with maven poms and the .gitattributes defining CRLF as line ending that breaks the renovate parser.

The analysis, to find a relation to line endings, is pretty time-consuming, because you cannot directly see, what the problem is. The only issues you see, are parsing errors that cannot be reproduced when you move those parts to another project.

Maybe it would be good idea, to provide a warning in the logs when unsupported line endings are found?

[rarkins]

PR welcome