Azure DevOps - Failed to add reviewers

[JamieMagee]

What Renovate type are you using?
Renovate CLI

Describe the bug
With the following renovate.json I am unable to automatically add reviewers to PRs created by renovate.

{
  "extends": ["config:base", ":rebaseStalePrs"],
  "reviewers": ["MY_EMAIL_ADDRESS"]
}

Did you see anything helpful in debug logs?

Failed to add reviewers (repository=..., dependencies=gradle, branch=renovate/gradle-5.x)
"assignees": [],
"err": {
  "message": "azureApiCore.getTeamMembers is not a function",
  "stack": "TypeError: azureApiCore.getTeamMembers is not a function\n    at Promise.all.teams.map (/home/jamie/.npm/_npx/24728/lib/node_modules/renovate/lib/platform/azure/index.js:574:28)\n    at Array.map (<anonymous>)\n    at Object.addReviewers (/home/jamie/.npm/_npx/24728/lib/node_modules/renovate/lib/platform/azure/index.js:571:11)\n    at processTicksAndRejections (internal/process/next_tick.js:81:5)"
}

Expected behavior
I expect to be able to add required reviewers to PRs based on email address

[rarkins]

It seems that the API endpoint(s) used for Azure DevOps have changed and we need to work out the new way or disable reviewers completely for Azure so that we don't error.

Replace or remove:

renovate/lib/platform/azure/index.js

Lines 480 to 522 in 1d9167b

	async function addReviewers(prNo, reviewers) {
	logger.trace(`addReviewers(${prNo}, ${reviewers})`);
	const azureApiGit = await azureApi.gitApi();
	const azureApiCore = await azureApi.getCoreApi();
	const repos = await azureApiGit.getRepositories();
	const repo = repos.filter(c => c.id === config.repoId)[0];
	const teams = await azureApiCore.getTeams(repo.project.id);
	const members = await Promise.all(
	teams.map(
	async t =>
	/* eslint-disable no-return-await */
	await azureApiCore.getTeamMembers(repo.project.id, t.id)
	)
	);
	const ids = [];
	members.forEach(listMembers => {
	listMembers.forEach(m => {
	reviewers.forEach(r => {
	if (
	r.toLowerCase() === m.displayName.toLowerCase() ||
	r.toLowerCase() === m.uniqueName.toLowerCase()
	) {
	if (ids.filter(c => c.id === m.id).length === 0) {
	ids.push({ id: m.id, name: r });
	}
	}
	});
	});
	});
	await Promise.all(
	ids.map(async obj => {
	await azureApiGit.createPullRequestReviewer(
	{},
	config.repoId,
	prNo,
	obj.id
	);
	logger.info(`Reviewer added: ${obj.name}`);
	})
	);
	}

[JamieMagee]

There's a new major version of azure-devops-node-api (breaking? Not sure if they follow semver). Perhaps that's useful? @renovate[bot] opened a PR about it in #2958.

[rarkins]

Yes, there's a new major available. I'll trigger the PR so that we can test it and see if the breaking changes affect us or not.

[renovate-bot]

🎉 This issue has been resolved in version 15.17.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀