Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maven datasource: use hunt registryStrategy #22744

Closed
Tracked by #23911
rarkins opened this issue Jun 13, 2023 · 3 comments · Fixed by #24588
Closed
Tracked by #23911

Maven datasource: use hunt registryStrategy #22744

rarkins opened this issue Jun 13, 2023 · 3 comments · Fixed by #24588
Labels
breaking Breaking change, requires major version bump datasource:maven priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:blocked Issue is blocked by another issue or external requirement type:bug Bug fix of existing functionality v37

Comments

@rarkins
Copy link
Collaborator

rarkins commented Jun 13, 2023

Describe the proposed change(s).

Renovate should fetch packages using registryStrategy=hunt.

It's important though that we have the registries listed in the right order whenever possible.

Describe why we need/want these change(s).

This is to align with https://maven.apache.org/guides/mini/guide-multiple-repositories.html#repository-order
@rarkins rarkins added type:bug Bug fix of existing functionality priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others datasource:maven status:ready labels Jun 13, 2023
@fredrondina fredrondina mentioned this issue Jun 13, 2023
Closed
6 tasks
@rarkins rarkins mentioned this issue Jun 16, 2023
Open
@rarkins
Copy link
Collaborator Author

rarkins commented Jun 16, 2023

Blocked by #22811

@viceice viceice added status:blocked Issue is blocked by another issue or external requirement and removed status:ready labels Jun 16, 2023
@rarkins rarkins added the breaking Breaking change, requires major version bump label Sep 13, 2023
@rarkins rarkins mentioned this issue Aug 22, 2023
Closed
5 tasks
@rarkins rarkins added the v37 label Sep 22, 2023
rarkins added a commit that referenced this issue Sep 22, 2023
@rarkins
feat(maven)!: use hunt strategy for registries
3ee8cd4 
Switch from "merge" strategy to "hunt" strategy to match with how Maven works.

Closes #22744

BREAKING CHANGE: Maven datasource no longer checks all registries and instead stops when it finds a package in one registry.
@rarkins rarkins mentioned this issue Sep 22, 2023
Merged
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 37.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@JakeWharton
Copy link
Contributor

Hi @rarkins. The linked behavior is not how build tools resolve the set of which versions are available, but how they resolve a single, specific coordinate triple (i.e., one containing an explicit version). As a result, the associated change for this issue will silently cause many version updates to be missed.

I have detailed the problem as best I could with examples in both Gradle and Maven here: #25461.

Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
breaking Breaking change, requires major version bump datasource:maven priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:blocked Issue is blocked by another issue or external requirement type:bug Bug fix of existing functionality v37
Projects
None yet
Milestone
No milestone
4 participants
@JakeWharton @viceice @rarkins @renovate-release