-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace dockerImagePrefix with configurable sidecar image #21217
Comments
We should also add the version to a const, so we can validate on |
Reproduction for regexManager which will update the sidecarImage verison in renovate repo: RegexManager: {
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"regexManagers": [
{
"fileMatch": ["config/options/index.ts"],
"matchStrings": [
"default: 'ghcr.io/containerbase/sidecar:(?<currentValue>.*)'"
],
"depNameTemplate": "containerbase/sidecar",
"datasourceTemplate": "docker"
}
]
} |
Should both the replacement and regexManager be added in the same PR? |
Yes |
use docker datasource instead of GitHub releases, because on a publish failure the image can be missing |
also node versioning is wrong. use leave versioning empty to use docker versioning |
Updated |
Closes #21217 BREAKING CHANGE: dockerImagePrefix is now replaced by dockerSidecarImage
Closes #21217 BREAKING CHANGE: dockerImagePrefix is now replaced by dockerSidecarImage
🎉 This issue has been resolved in version 36.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
What would you like Renovate to be able to do?
Allow a configurable/deterministic sidecar image to be configured for self-hosted users.
If you have any ideas on how this should be implemented, please tell us here.
Remove
dockerImagePrefix
as a config option.Add
sidecarImage
as a new global config option, defaulting tocontainerbase/sidecar:x.y.z
. It should be used instead during binarySource=docker sidecar executions.No need to migrate - we should declare it as a breaking change.
Also configure a regex manager to keep sidecar updated within the Renovate repo.
Is this a feature you are interested in implementing yourself?
No
The text was updated successfully, but these errors were encountered: