Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ArgoCD multisource support #20647

Closed
piximos opened this issue Feb 27, 2023 · 2 comments · Fixed by #20648
Closed

Add ArgoCD multisource support #20647

piximos opened this issue Feb 27, 2023 · 2 comments · Fixed by #20648
Assignees
@piximos
Labels
manager:argocd Related to the ArgoCD package manager priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:feature Feature (new functionality)

Comments

@piximos
Copy link
Contributor

piximos commented Feb 27, 2023

What would you like Renovate to be able to do?

Add support for ArgoCD's MultiSource that has been introduced in v2.6.0

If you have any ideas on how this should be implemented, please tell us here.

In the new ArgoCD release, in addition to the .spec.source field in the Application resource and the .spec.template.spec.source field in the ApplicationSet resource, ArgoCD now allows for defining multiple sources as an array in the .spec.sources field in the Application resource and the .spec.template.spec.sources. This should be accounted for.

Is this a feature you are interested in implementing yourself?

Yes
@piximos piximos added priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality) labels Feb 27, 2023
@secustor secustor added priority-4-low Low priority, unlikely to be done unless it becomes important to more people status:ready manager:argocd Related to the ArgoCD package manager and removed status:requirements Full requirements are not yet known, so implementation should not be started priority-5-triage labels Feb 27, 2023
@secustor
Copy link
Collaborator

If you need pointers, feel free ask them here or in the DEV slack channel.

@piximos piximos mentioned this issue Feb 27, 2023
Merged
6 tasks
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 35.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@piximos piximos

Labels
manager:argocd Related to the ArgoCD package manager priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:feature Feature (new functionality)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(manager/argocd): added support for argocd multisource hey-car/renovate
3 participants
@secustor @piximos @renovate-release