-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(manager/argocd): added support for argocd multisource #20648
feat(manager/argocd): added support for argocd multisource #20648
Conversation
9588771
to
d5109fe
Compare
d5109fe
to
db42083
Compare
7eab31b
to
577bbc7
Compare
Please do not force push on ready PRs, if not necessary. https://github.com/renovatebot/renovate/blob/main/.github/contributing.md#do-not-force-push-to-your-pull-request-branch |
577bbc7
to
9fcdd2d
Compare
Sorry for the force push |
Needs code coverage. |
…7/add-argocd-multisource
Still needs coverage. This is line is missing: |
removed return empty in createDependency as it will never be executed due to the typing of the ApplicationDefinition's kind attribute. All the variations of this field have been checked in prior steps and the removed line will never be executed
Removed |
…7/add-argocd-multisource
This will fail to compile now as there is no return value in all execution branches. Simply add another test with an inline fixture of a Project CRD and you should be good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, don't export helper functions. just use appropriate inline fixtures
…7/add-argocd-multisource
…7/add-argocd-multisource
…7/add-argocd-multisource
…7/add-argocd-multisource
…7/add-argocd-multisource
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You do not have to merge main as this will handled by the merge queue.
🎉 This PR is included in version 35.13.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
Added support for ArgoCD MultiSource
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: