Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/argocd): added support for argocd multisource #20648

Merged
merged 18 commits into from
Mar 19, 2023

Conversation

piximos
Copy link
Contributor

@piximos piximos commented Feb 27, 2023

Changes

Added support for ArgoCD MultiSource

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@CLAassistant
Copy link

CLAassistant commented Feb 27, 2023

CLA assistant check
All committers have signed the CLA.

@piximos piximos force-pushed the feat-20647/add-argocd-multisource branch from 9588771 to d5109fe Compare February 27, 2023 14:04
@piximos piximos force-pushed the feat-20647/add-argocd-multisource branch from d5109fe to db42083 Compare February 27, 2023 14:13
@piximos piximos marked this pull request as ready for review February 27, 2023 14:14
@viceice viceice changed the title feat: added support for argocd multisource feat(manager/argocd): added support for argocd multisource Feb 27, 2023
lib/modules/manager/argocd/types.ts Outdated Show resolved Hide resolved
lib/modules/manager/argocd/types.ts Outdated Show resolved Hide resolved
lib/modules/manager/argocd/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/argocd/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/argocd/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/argocd/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/argocd/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/argocd/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/argocd/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/argocd/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/argocd/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/argocd/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/argocd/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/argocd/extract.ts Outdated Show resolved Hide resolved
@piximos piximos force-pushed the feat-20647/add-argocd-multisource branch 2 times, most recently from 7eab31b to 577bbc7 Compare February 27, 2023 15:27
@secustor
Copy link
Collaborator

Please do not force push on ready PRs, if not necessary. https://github.com/renovatebot/renovate/blob/main/.github/contributing.md#do-not-force-push-to-your-pull-request-branch

@piximos piximos force-pushed the feat-20647/add-argocd-multisource branch from 577bbc7 to 9fcdd2d Compare February 27, 2023 15:29
@piximos
Copy link
Contributor Author

piximos commented Feb 27, 2023

Sorry for the force push

lib/modules/manager/argocd/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/argocd/extract.ts Outdated Show resolved Hide resolved
@secustor
Copy link
Collaborator

Needs code coverage.

lib/modules/manager/argocd/extract.spec.ts Show resolved Hide resolved
lib/modules/manager/argocd/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/argocd/extract.ts Outdated Show resolved Hide resolved
@secustor
Copy link
Collaborator

secustor commented Feb 28, 2023

Still needs coverage. This is line is missing:
https://github.com/renovatebot/renovate/pull/20648/files#diff-de5a018e5a8529dc329235872d68a919609bbdbb0e15bf7d19821fea28df153aR31
else the test will keep failing

removed return empty in createDependency as it will never be executed due to the typing of the ApplicationDefinition's kind attribute.
All the variations of this field have been checked in prior steps and the removed line will never be executed
@piximos
Copy link
Contributor Author

piximos commented Feb 28, 2023

Removed return[] in createDependency (referenced here) as it will never be executed due to the typing of the ApplicationDefinition's kind attribute.
All the variations of this field have been checked in prior steps and the removed line will never be executed

@secustor
Copy link
Collaborator

This will fail to compile now as there is no return value in all execution branches.

Simply add another test with an inline fixture of a Project CRD and you should be good to go.

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, don't export helper functions. just use appropriate inline fixtures

Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You do not have to merge main as this will handled by the merge queue.

lib/modules/manager/argocd/extract.ts Outdated Show resolved Hide resolved
@secustor secustor requested a review from viceice March 9, 2023 09:08
@viceice viceice added this pull request to the merge queue Mar 19, 2023
@viceice viceice merged commit 1292e75 into renovatebot:main Mar 19, 2023
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ArgoCD multisource support
5 participants