depName/lookupName -> depName/packageName #14341
Labels
breaking
Breaking change, requires major version bump
status:in-progress
Someone is working on implementation
type:refactor
Refactoring or improving of existing code
Describe the proposed change(s).
Our approach to extracting and looking up dependencies might be easier to understand and align with external concepts if we:
packageName
instead oflookupName
(it's a package name we look up)packageName
and extractdepName
only if there's some sort of "alias" or "short name" for it, which 95% of the time doesn't happenA challenge would be how to handle
matchPackage...
matching inpackageRules
. Most of the timedepName===lookupName
so it gets the same result, but there's times when we have a "short" name fordepName
which is currently being matched, and actually we have no way to match a package rule againstlookupName
. In future I would likedepName
to be mostly cosmetic but happy to addmatchDepNames
. The challenge is if we switchmatchPackageNames
to match againstpackageName
then there may be some existing rules which no longer match.Perhaps we could add
matchDepNames
, and then withmatchPackageNames
we first try to match againstpackageName
and then fall back todepName
and warn of a migration need is there's a match?The text was updated successfully, but these errors were encountered: