Refactor/rename directory structure

[rarkins]

I'm thinking of ways to restructure our source code inside lib/ for easier understanding. Ideas include:

• Moving datasource, manager, platform and versioning under a new modules/ subdirectory
• Restructuring workers so that the source code is sorted closer to execution order

After these changes, it would leave the following under lib/: config, constants, logger, types and util.

[viceice]

This would help for docs too, because currently we need to change the levels, which should hopefully make cross links easier.

[rarkins]

I want to do this on the next major release:

lib/
  modules/
    datasource/
    manager/
    platform/
    versioning/
  workers/
    global/
      config/
      init/
      run/
      teardown/
    repository/
      config/
      extract/
      lookup/
      update/
        branch/
        pr/

From experimenting on modules today, I found that the follow-up tasks included:

• Updating the ts strict config
• Looking for jest.mock('../ and adding an extra ../ to it
• Updating snapshots

[rarkins]

After modules moving, replace:

• jest.mock\('(\.\./(util|config|logger)) in lib/modules with jest.mock('../$1
• \.\./(datasource|manager|platform|versioning) in lib/(config|constants|util|workers) with ../modules/$1
• \.\./(config|constants|logger|util|workers|test|types) in lib/modules/ with ../../$1
• more..

[viceice]

VSCode can auto update imports when moving via drag'n'drop.

[rarkins]

I know, but for some reason it's not getting all of them. It doesn't catch jest.mock() either

[PhilipAbed]

@viceice nope, github/ webstorm/ vs code, i checked all, none of them move imports or any hardcoded tests/mocks, doing everything manually with regexes

[rarkins]

I can confirm that typescript.updateImportsOnFileMove.enabled does work, especially for imports. But:

• it seems like VSCode can get overloaded and not catch them all, so I recommend small updates at a time (e.g. move one modules at a time)
• it misses jest.mock() because that's library-specific and not a JS/TS concept

[rarkins]

Let's do just the potentially "breaking" changes for now:

• All modules
• Move branch and pr workers under global worker

[rarkins]

Some observations:

VSCode indeed does a good job of updating imports. But beware:

• Make sure you've opened at least one .ts file since restarting, or else the "ESLint server" won't be running
• After moving a folder, and letting VSCode make the changes, you should wait until the errors/warnings in the bottom bar stabilize and no longer change in count. Only once this is stable can you be free to "Save All" tabs and then Close All

Most of what's left is jest.import() and a few require() statements which were missed, plus replacing any lib/x references to modules to lib/modules/x

[rarkins]

This was mostly implemented in #14490. Remaining parts are no longer "breaking"