Renovate partly reporting ArgoCD deps updates

[fad3t]

How are you running Renovate?

Self-hosted Renovate

If you're self-hosting Renovate, tell us what version of Renovate you run.

36.91

If you're self-hosting Renovate, select which platform you are using.

GitLab self-hosted

Was this something which used to work for you, and then stopped?

I am trying to get this working for the first time

Describe the problem

Hello,

I'm using Renovate to automatically upgrade ArgoCD apps.
The configuration relevant to the ArgoCD manager is the following:

  "argocd": {
    "fileMatch": [
      "-app\\.ya?ml$",
      "addons\\.ya?ml$"
    ]
  },

I have configured Renovate to scan a repository where multiple addons.yaml files have been put.
However, I have noticed Renovate creates a PR only for a few of them.

The logs seem to indicate the fileMatch expression is OK - I have a total of 19 files matching (see logs below).
I have the impression Renovate only creates a PR when the repoURL isn't double-quoted:

This is correctly processed - a PR is created:

---
apiVersion: "argoproj.io/v1alpha1"
kind: "Application"
metadata:
  name: "addons"
  namespace: "argocd"
spec:
  project: "default"
  source:
    repoURL: https://my.registry/helm/
    targetRevision: "0.4.3"
    chart: "addons"
    <snip>

This is kind of ignored by Renovate:

---
apiVersion: "argoproj.io/v1alpha1"
kind: "Application"
metadata:
  name: "addons"
  namespace: "argocd"
spec:
  project: "default"
  source:
    repoURL: "https://my.registry/helm/"
    targetRevision: "0.4.3"
    chart: "addons"
    <snip>

Here's the reproduction repo: https://github.com/fad3t/renovate-argocd

Thanks,
Fred

Relevant debug logs

DEBUG: Matched 19 file(s) for manager argocd: clusters/c01/addons.yaml, clusters/c02/addons.yaml, <snip> (repository=config/argocd)
DEBUG: Matched 1 file(s) for manager gitlabci: .gitlab-ci.yml (repository=config/argocd)
DEBUG: Matched 1 file(s) for manager gitlabci-include: .gitlab-ci.yml (repository=config/argocd)
DEBUG: manager extract durations (ms) (repository=config/argocd)
       "managers": {"gitlabci": 5, "gitlabci-include": 4, "argocd": 9}
DEBUG: Found argocd package files (repository=config/argocd)
DEBUG: Found gitlabci package files (repository=config/argocd)
DEBUG: Found 4 package file(s) (repository=config/argocd)
 INFO: Dependency extraction complete (repository=config/argocd, baseBranch=main)
       "stats": {
         "managers": {
           "argocd": {"fileCount": 3, "depCount": 3},
           "gitlabci": {"fileCount": 1, "depCount": 1}
         },
         "total": {"fileCount": 4, "depCount": 4}
       }

Have you created a minimal reproduction repository?

I have linked to a minimal reproduction in the description above: https://github.com/fad3t/renovate-argocd

[secustor]

The renovate.json of the reproduction repo does not contain any fileMatch.
Also if running debug mode there is a JSON printed with all found dependencies and a skipReason if the dependency is discarded.
We need that to give you additional information.

[fad3t]

Indeed, the fileMatch is part of the global config - on the bot side. I'll move it into the config of the repository.

Regarding the found deps, only the 4 identified by Renovate are listed:

DEBUG: packageFiles with updates (repository=config/argocd, baseBranch=main)
       "config": {
         "argocd": [
           {
             "deps": [
               {
                 "depName": "addons",
                 "registryUrls": [
                   "https://my.registry/helm/"
                 ],
                 "currentValue": "0.2.4",
                 "datasource": "helm",
                 "updates": [
                   {
                     "bucket": "non-major",
                     "newVersion": "0.4.8",
                     "newValue": "0.4.8",
                     "newDigest": "d16d6529459d8ef7244e60d3afbcb5cc61aeaaafa83b672c5c97f53d24d19d06",
                     "releaseTimestamp": "2023-09-11T08:11:18.898Z",
                     "newMajor": 0,
                     "newMinor": 4,
                     "updateType": "minor",
                     "branchName": "renovate/addons-0.x"
                   }
                 ],
                 "packageName": "addons",
                 "versioning": "helm",
                 "warnings": [],
                 "sourceUrl": "<snip>",
                 "registryUrl": "https://my.registry/helm",
                 "currentVersion": "0.2.4",
                 "isSingleVersion": true,
                 "fixedVersion": "0.2.4"
               }
             ],
             "packageFile": "clusters/c01/addons.yaml"
           },
           {
             "deps": [
               {
                 "depName": "addons",
                 "registryUrls": [
                   "https://my.registry/helm/"
                 ],
                 "currentValue": "0.4.3",
                 "datasource": "helm",
                 "updates": [
                   {
                     "bucket": "non-major",
                     "newVersion": "0.4.8",
                     "newValue": "0.4.8",
                     "newDigest": "d16d6529459d8ef7244e60d3afbcb5cc61aeaaafa83b672c5c97f53d24d19d06",
                     "releaseTimestamp": "2023-09-11T08:11:18.898Z",
                     "newMajor": 0,
                     "newMinor": 4,
                     "updateType": "patch",
                     "branchName": "renovate/addons-0.x"
                   }
                 ],
                 "packageName": "addons",
                 "versioning": "helm",
                 "warnings": [],
                 "sourceUrl": "<snip>",
                 "registryUrl": "https://my.registry/helm",
                 "currentVersion": "0.4.3",
                 "isSingleVersion": true,
                 "fixedVersion": "0.4.3"
               }
             ],
             "packageFile": "clusters/c02/addons.yaml"
           },
           {
             "deps": [
               {
                 "depName": "vault",
                 "registryUrls": [
                   "https://my.registry/helm/"
                 ],
                 "currentValue": "0.0.10",
                 "datasource": "helm",
                 "updates": [],
                 "packageName": "vault",
                 "versioning": "helm",
                 "warnings": [],
                 "registryUrl": "https://my.registry/helm",
                 "currentVersion": "0.0.10",
                 "fixedVersion": "0.0.10"
               }
             ],
             "packageFile": "clusters/c02/vault-app.yaml"
           }
         ],
         "gitlabci": [
           {
             <snip>
           }
         ]
       }

[secustor]

I have identified the issue.
We do not expect the apiVersion value to be quoted as this is unnecessary and usually isn't been done.

I'm preparing a PR to fix this, but as workaround simply do this

-apiVersion: "argoproj.io/v1alpha1"
+apiVersion: argoproj.io/v1alpha1

As context we check for this line to reduce overhead of parsing yaml documents when they do not contain ArgoCD manifests.

[fad3t]

Great, thanks!

[secustor]

PR to fix this issue: #24355