Apply suggestions from code review

Co-authored-by: Michael Kriese <[email protected]>
renovatebot · May 17, 2023 · ecc2f9c · ecc2f9c
1 parent 3c7f011
commit ecc2f9c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/lib/modules/manager/pep621/processors/pdm.spec.ts b/lib/modules/manager/pep621/processors/pdm.spec.ts
@@ -67,7 +67,7 @@ describe('modules/manager/pep621/processors/pdm', () => {
       ]);
     });
 
-    it('rethrow error', async () => {
+    it('returns artifact error', async () => {
       const execSnapshots = mockExecAll();
       GlobalConfig.set({ ...adminConfig, binarySource: 'docker' });
       fs.getSiblingFileName.mockReturnValueOnce('pdm.lock');

diff --git a/lib/modules/manager/pep621/processors/pdm.ts b/lib/modules/manager/pep621/processors/pdm.ts
@@ -79,12 +79,12 @@ export class PdmProcessor implements PyProjectProcessor {
       // else only update specific packages
       let packageList = '';
       if (!isLockFileMaintenance) {
-        packageList = updatedDeps
-          .map((value) => value.packageName ?? value.depName)
+        packageList = ' ' + updatedDeps
+          .map((value) => value.packageName)
           .join(' ');
       }
-      const cmd = `pdm update ${packageList}`;
-      await exec([cmd], execOptions);
+      const cmd = `pdm update${packageList}`;
+      await exec(cmd, execOptions);
 
       // check for changes
       const fileChanges: UpdateArtifactsResult[] = [];
@@ -102,7 +102,7 @@ export class PdmProcessor implements PyProjectProcessor {
         logger.debug('pdm.lock is unchanged');
       }
 
-      return fileChanges.length > 0 ? fileChanges : null;
+      return fileChanges.length ? fileChanges : null;
     } catch (err) {
       // istanbul ignore if
       if (err.message === TEMPORARY_ERROR) {