Apply suggestions from code review

Co-authored-by: HonkingGoose <[email protected]>
renovatebot · Jul 22, 2024 · 59fff72 · 59fff72
1 parent 74f14c6
commit 59fff72
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/docs/usage/self-hosted-configuration.md b/docs/usage/self-hosted-configuration.md
@@ -1158,9 +1158,9 @@ If set, Renovate will use this string as the `endpoint` when creating the AWS S3
 
 If set, Renovate will enable `forcePathStyle` when creating the AWS S3 client instance.
 
-> Whether to force path-style URLs for S3 objects (e.g., `https://s3.amazonaws.com//` instead of `https://.s3.amazonaws.com/`)
+Quote from [AWS S3 documentation - Interface BucketEndpointInputConfig](https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/clients/client-s3/interfaces/bucketendpointinputconfig.html):
 
-Source: [AWS S3 documentation - Interface BucketEndpointInputConfig](https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/clients/client-s3/interfaces/bucketendpointinputconfig.html)
+> Whether to force path-style URLs for S3 objects (e.g., `https://s3.amazonaws.com//` instead of `https://.s3.amazonaws.com/`)
 
 ## secrets
 

diff --git a/lib/util/s3.spec.ts b/lib/util/s3.spec.ts
@@ -26,7 +26,7 @@ describe('util/s3', () => {
     expect(client1).toBe(client2);
   });
 
-  it('uses user configured s3 values', async () => {
+  it('uses user-configured s3 values', async () => {
     const s3 = await import('./s3');
     const globalConfig = await import('../config/global');
     globalConfig.GlobalConfig.set({

diff --git a/lib/util/s3.ts b/lib/util/s3.ts
@@ -6,7 +6,7 @@ import { parseUrl } from './url';
 
 let s3Instance: S3Client | undefined;
 export function getS3Client(
-  // not necessary unless GlobalConfig is not initialized due to some error
+  // Only needed if GlobalConfig is not initialized due to some error
   s3Endpoint?: string,
   s3PathStyle?: boolean,
 ): S3Client {

diff --git a/lib/workers/global/config/parse/index.ts b/lib/workers/global/config/parse/index.ts
@@ -113,7 +113,7 @@ export async function parseConfigs(
     config.forkProcessing = 'enabled';
   }
 
-  // Try deletion only if RENOVATE_CONFIG_FILE is specified
+  // Only try deletion if RENOVATE_CONFIG_FILE is set
   await fileParser.deleteNonDefaultConfig(env, !!config.deleteConfigFile);
 
   // Remove log file entries