Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

member() to check for namedMembers length #117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

4vanger
Copy link

@4vanger 4vanger commented Jun 8, 2020

Run into a problem having an import like

import 'nprogress/nprogress.css';

and sorting rule like

            sort: member(unicode),

Import object will look like:

{
  start: 340,
  end: 372,
  importStart: 340,
  importEnd: 372,
  type: 'import',
  moduleName: 'nprogress/nprogress.css',
  namedMembers: []
}

and sorting will throw.
Solution: add check for array length, let it return undefined and sort based on that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant