style (FEDERATION) nuwave#911: Code style adjustments to match requir…

…ements
renepardon · Nov 25, 2019 · f2ab7dd · f2ab7dd
1 parent ca1f4b7
commit f2ab7dd
Show file tree

Hide file tree

Showing 7 changed files with 53 additions and 55 deletions.
diff --git a/src/Federation/Directives/ExtendsDirective.php b/src/Federation/Directives/ExtendsDirective.php
@@ -6,16 +6,6 @@
 
 class ExtendsDirective extends BaseDirective
 {
-    /**
-     * Directive name.
-     *
-     * @return string
-     */
-    public function name(): string
-    {
-        return 'extends';
-    }
-
     /**
      * @return string
      * @see https://www.apollographql.com/docs/apollo-server/federation/federation-spec/#schema-modifications-glossary
@@ -37,4 +27,14 @@ public static function definition(): string
 directive @extends on OBJECT | INTERFACE
 SDL;
     }
+
+    /**
+     * Directive name.
+     *
+     * @return string
+     */
+    public function name(): string
+    {
+        return 'extends';
+    }
 }
diff --git a/src/Federation/Directives/ExternalDirective.php b/src/Federation/Directives/ExternalDirective.php
@@ -6,16 +6,6 @@
 
 class ExternalDirective extends BaseDirective
 {
-    /**
-     * Name of the directive.
-     *
-     * @return string
-     */
-    public function name(): string
-    {
-        return 'external';
-    }
-
     /**
      * @return string
      * @see https://www.apollographql.com/docs/apollo-server/federation/federation-spec/#schema-modifications-glossary
@@ -32,4 +22,14 @@ public static function definition(): string
 directive @external on FIELD_DEFINITION
 SDL;
     }
+
+    /**
+     * Name of the directive.
+     *
+     * @return string
+     */
+    public function name(): string
+    {
+        return 'external';
+    }
 }
diff --git a/src/Federation/Directives/KeyDirective.php b/src/Federation/Directives/KeyDirective.php
@@ -6,16 +6,6 @@
 
 class KeyDirective extends BaseDirective
 {
-    /**
-     * Directive name.
-     *
-     * @return string
-     */
-    public function name(): string
-    {
-        return 'key';
-    }
-
     /**
      * @return string
      * @see https://www.apollographql.com/docs/apollo-server/federation/federation-spec/#schema-modifications-glossary
@@ -38,4 +28,14 @@ public static function definition(): string
 ) on OBJECT | INTERFACE
 SDL;
     }
+
+    /**
+     * Directive name.
+     *
+     * @return string
+     */
+    public function name(): string
+    {
+        return 'key';
+    }
 }
diff --git a/src/Federation/Directives/ProvidesDirective.php b/src/Federation/Directives/ProvidesDirective.php
@@ -6,16 +6,6 @@
 
 class ProvidesDirective extends BaseDirective
 {
-    /**
-     * Name of the directive.
-     *
-     * @return string
-     */
-    public function name(): string
-    {
-        return 'provides';
-    }
-
     /**
      * @return string
      * @see https://www.apollographql.com/docs/apollo-server/federation/federation-spec/#schema-modifications-glossary
@@ -46,4 +36,14 @@ public static function definition(): string
 ) on FIELD_DEFINITION
 SDL;
     }
+
+    /**
+     * Name of the directive.
+     *
+     * @return string
+     */
+    public function name(): string
+    {
+        return 'provides';
+    }
 }
diff --git a/src/Federation/Directives/RequiresDirective.php b/src/Federation/Directives/RequiresDirective.php
@@ -6,16 +6,6 @@
 
 class RequiresDirective extends BaseDirective
 {
-    /**
-     * Name of the directive.
-     *
-     * @return string
-     */
-    public function name(): string
-    {
-        return 'requires';
-    }
-
     /**
      * @return string
      * @see https://www.apollographql.com/docs/apollo-server/federation/federation-spec/#schema-modifications-glossary
@@ -44,4 +34,14 @@ public static function definition(): string
 ) on FIELD_DEFINITION
 SDL;
     }
+
+    /**
+     * Name of the directive.
+     *
+     * @return string
+     */
+    public function name(): string
+    {
+        return 'requires';
+    }
 }
diff --git a/src/Federation/FederationServiceProvider.php b/src/Federation/FederationServiceProvider.php
@@ -115,7 +115,7 @@ protected function addScalars(ManipulateAST &$manipulateAST): void
 
     /**
      * Retrieve all object types from AST which uses the @key directive (no matter if native or extended type) and
-     * combine those types into the _Entity union
+     * combine those types into the _Entity union.
      *
      * @param ManipulateAST $manipulateAST
      *

diff --git a/src/Federation/Resolvers/Service.php b/src/Federation/Resolvers/Service.php
@@ -4,8 +4,6 @@
 
 use GraphQL\Type\Definition\ObjectType;
 use GraphQL\Type\Definition\ResolveInfo;
-use GraphQL\Type\Schema;
-use GraphQL\Type\SchemaConfig;
 use GraphQL\Utils\SchemaPrinter;
 use Nuwave\Lighthouse\Support\Contracts\GraphQLContext;
 
@@ -29,14 +27,14 @@ public function resolveSdl($rootValue, array $args, GraphQLContext $context, Res
 
         $queryFields = [];
         foreach ($schema->getQueryType()->getFields() as $field) {
-            if (!in_array($field->name, static::FEDERATION_QUERY_FIELDS)) {
+            if (! in_array($field->name, static::FEDERATION_QUERY_FIELDS)) {
                 $queryFields[] = $field;
             }
         }
 
         $directives = [];
         foreach ($schema->getDirectives() as $directive) {
-            if (!in_array($directive->name, static::FEDERATION_DIRECTIVES)) {
+            if (! in_array($directive->name, static::FEDERATION_DIRECTIVES)) {
                 $directives[] = $directive;
             }
         }