forked from cockroachdb/cockroach
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
roachtest: collect failure artifacts when restore fails
This commit updates the `backup-restore/mixed-version` roachtest to collect artifacts (cockroach logs and a debug.zip) when a restore fails in the last step of the test (when all backups taken are restored). In that step, we do not immediately fail the test when a restore fails but instead attempt to restore every backup and return a list of errors found when the process is done. However, restoring cluster backups involves wiping the cluster which also deletes existing cockroach logs up to that point. This makes debugging a restore failure that happened prior to a cluster restore impossible. After this commit, a restore failure in that test will cause a `restore_failure_N` directory to be created in the artifacts directory, including the cockroach logs collected right after the failure, as well as a debug.zip created at the same time. This will make issues such as cockroachdb#104604 more actionable. Epic: none Release note: None
- Loading branch information
1 parent
f88077d
commit 86c4583
Showing
4 changed files
with
46 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters