Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add out of the box support for spark benchmarks on JDK16 #244

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Add out of the box support for spark benchmarks on JDK16 #244

merged 1 commit into from
Apr 29, 2021

Conversation

farquet
Copy link
Collaborator

@farquet farquet commented Apr 27, 2021 •
edited
Loading

Partially addresses #241

@lbulej
Copy link
Member

lbulej commented Apr 29, 2021

There was a fluke in the test run, so after restarting the build, it passed the tests.

I have just a minor nitpick: can you make add_opens_packages into addOpensPackages to fit the naming style in the file?

@farquet farquet force-pushed the ff/jdk16-add-opens branch from 42733c7 to 5bcdab8 Compare April 29, 2021 16:57
@farquet
Copy link
Collaborator Author

farquet commented Apr 29, 2021

@lbulej I've been coding too much in Python. My bad.
I fixed the variable name. There is nothing more annoying than such inconsistencies.

@farquet farquet merged commit fd65310 into master Apr 29, 2021
@farquet farquet deleted the ff/jdk16-add-opens branch April 30, 2021 10:00
@lbulej lbulej mentioned this pull request Apr 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbulej lbulej lbulej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@farquet @lbulej