Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly pass ignored rules to chokidar #1214

Merged
merged 3 commits into from
Jan 8, 2018
Merged

fix: correctly pass ignored rules to chokidar #1214

merged 3 commits into from
Jan 8, 2018

Conversation

remy
Copy link
Owner

@remy remy commented Jan 6, 2018

Previous the rules weren't matching fully inside of chokidar, requiring
that, for instance, node_modules is written as /node_modules/.

I've also tidied up what's printed in verbose mode, so it doesn't print
default ignores, and doesn't print the full path of an ignored
directory.

This change also fixes notifications from chokidar from user ignored
paths (using the cwd argument). This should fix #1202

Previous the rules weren't matching fully inside of chokidar, requiring
that, for instance, node_modules is written as **/node_modules/**.

I've also tidied up what's printed in verbose mode, so it doesn't print
default ignores, and doesn't print the full path of an ignored
directory.

This change _also_ fixes notifications from chokidar from user ignored
paths (using the `cwd` argument). This should fix #1202
@remy remy merged commit c121187 into master Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nodemon tries to watch ignored folder -> error
1 participant