Skip to content

Commit

Permalink
fix extension initialization (fixes allure-framework#123)
Browse files Browse the repository at this point in the history
  • Loading branch information
remorhaz committed May 14, 2024
1 parent 97cfea0 commit 876f7f0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 8 deletions.
7 changes: 1 addition & 6 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ jobs:
- "8.0"
- "8.1"
- "8.2"
- "8.3"
os:
- ubuntu-latest
- windows-latest
Expand Down Expand Up @@ -49,10 +50,4 @@ jobs:
${{ matrix.composer-options }}

- name: Run tests
if: ${{ matrix.php-version != '8.2' }}
run: composer test

- name: Run tests (experimental)
if: ${{ matrix.php-version == '8.2' }}
continue-on-error: true
run: composer test
4 changes: 2 additions & 2 deletions src/AllureCodeception.php
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ final class AllureCodeception extends Extension
private const DEFAULT_RESULTS_DIRECTORY = 'allure-results';

protected static array $events = [
Events::MODULE_INIT => 'moduleInit',
Events::SUITE_BEFORE => 'suiteBefore',
Events::SUITE_AFTER => 'suiteAfter',
Events::TEST_START => 'testStart',
Expand All @@ -68,8 +67,9 @@ final class AllureCodeception extends Extension
* @throws ConfigurationException
* phpcs:disable PSR2.Methods.MethodDeclaration.Underscore
*/
public function moduleInit(): void
public function _initialize(): void
{
parent::_initialize();
QametaAllure::reset();
$this->testLifecycle = null;
$this->threadDetector = null;
Expand Down

0 comments on commit 876f7f0

Please sign in to comment.