Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle cycles between manual chunks #9917

Merged
merged 4 commits into from
Aug 28, 2024
Merged

Conversation

nornagon
Copy link
Contributor

I was running into "Maximum call stack size exceeded" in this walk() function. I don't have a minimal repro, but I think it was likely caused by circular dependencies either between things in the chunk and things not in the chunk, or things within the chunk itself. This change seems to fix it.

Testing Strategy:

Copy link

changeset-bot bot commented Aug 27, 2024

🦋 Changeset detected

Latest commit: 711b50f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Aug 27, 2024

Hi @nornagon,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Aug 28, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@jacob-ebey jacob-ebey changed the base branch from main to dev August 28, 2024 03:15
@jacob-ebey jacob-ebey merged commit 9c33057 into remix-run:dev Aug 28, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants