-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude ?inline
and ?raw
from critical styles in dev
#9910
Exclude ?inline
and ?raw
from critical styles in dev
#9910
Conversation
…y from being injected falsely - css files with query ?url, ?inline or ?raw shouldn't be injected on SSR bei vite spec - a combination of these query-params is possible. This is checked as well closes 9844
Hi @dj-rabel, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
🦋 Changeset detectedLatest commit: 7e7c153 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
?inline
and ?raw
from critical styles in dev
Thanks for the PR! This is a really great catch. I've pushed some refactors to make the code a little easier to follow by avoiding a regular expression, and expanded the tests a bit. |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
Closes: #9844
Testing Strategy:
?inline
imports #9844)-> Here it is: https://stackblitz.com/edit/vitejs-vite-qjxcev
-> And here executing dev without the override as a negative test https://stackblitz.com/edit/vitejs-vite-qjxcev?terminal=dev