-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename future flag from fogOfWar to lazyRouteDiscovery #9763
Conversation
🦋 Changeset detectedLatest commit: a47bfe3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
"@remix-run/dev": minor | ||
"@remix-run/react": minor | ||
"@remix-run/server-runtime": minor | ||
"@remix-run/testing": minor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did minor
here instead of patch
since I'm not considering this a change to a current flag but moreso the deletion
of a current flag and the introduction of a new one.
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
The "fog of war" phrasing is a nice metaphor for this and works well in blog posts but it's pretty confusing to see as a future flag without the proper context or video game familiarity. We're going to rename the flag for clarity and we'll still use the "fog of war" metaphor in docs and blog posts etc.