Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Fog of War form discovery and fix link prefetching #9665

Merged
merged 6 commits into from
Jun 27, 2024

Conversation

brophdawg11
Copy link
Contributor

  • We forgot to enable Fog of War discovery for <Form> components in the first pass
  • Add an E2E test to ensure that we can prefetch after FOW discovery - requires an RR prerelease before CI will pass

Copy link

changeset-bot bot commented Jun 27, 2024

🦋 Changeset detected

Latest commit: 86da2c0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/react Patch
@remix-run/testing Patch
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 merged commit bd4f873 into dev Jun 27, 2024
9 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/fog-of-war-updates branch June 27, 2024 20:11
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Jun 27, 2024
Copy link
Contributor

github-actions bot commented Jul 1, 2024

🤖 Hello there,

We just published version 2.10.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

github-actions bot commented Jul 3, 2024

🤖 Hello there,

We just published version 2.10.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Jul 3, 2024
let isAbsolute =
typeof props.action === "string" && ABSOLUTE_URL_REGEX.test(props.action);
return (
<RouterForm
Copy link
Member

@ryanflorence ryanflorence Jul 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we missed the <RouterForm ref={forwardedRef}>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants