Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typos and links in multiple pages #957

Merged
merged 2 commits into from
Dec 13, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions contributors.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
- crismali
- davecalnan
- derekr
- dhargitai
- dokeet
- dunglas
- edgesoft
Expand Down
2 changes: 1 addition & 1 deletion docs/api/conventions.md
Original file line number Diff line number Diff line change
Expand Up @@ -644,7 +644,7 @@ export const loader: LoaderFunction = async ({

See also:

- [`headers`]("#headers")
- [`headers`](#headers)
- [MDN Response Docs][response]

#### Throwing Responses in Loaders
Expand Down
3 changes: 1 addition & 2 deletions docs/api/remix.md
Original file line number Diff line number Diff line change
Expand Up @@ -2063,6 +2063,5 @@ import type {
[useloaderdata]: #useloaderdata
[usesubmit]: #usesubmit
[constraints]: ../other-api/constraints
[action]: ../app/#action
[loader]: ../app/#loader
[action]: #form-action
[disabling-javascript]: ../guides/disabling-javascript
4 changes: 2 additions & 2 deletions docs/tutorials/jokes.md
Original file line number Diff line number Diff line change
Expand Up @@ -3535,7 +3535,7 @@ export const loader: LoaderFunction = async () => {

Hopefully getting the user in the loader and rendering them in the component was pretty straightforward. There are a few things I want to call out about other parts of my version of the code before we continue.

First, the new `logout` route is just there to make it easy for us to logout. The reason that we're using an action (rather than a loader) is because want to avoid [CSRF](https://developer.mozilla.org/en-US/docs/Glossary/CSRF) problems by using a POST request rather than a GET request. This is why the logout button is a form and not a link. Additionally, Remix will only re-call our loaders when we perform an `action`, so if we used a `loader` then the cache would not get invalidated. The `loader` is just there in case someone somehow lands on that page, we'll just redirect them back home.
First, the new `logout` route is just there to make it easy for us to logout. The reason that we're using an action (rather than a loader) is because we want to avoid [CSRF](https://developer.mozilla.org/en-US/docs/Glossary/CSRF) problems by using a POST request rather than a GET request. This is why the logout button is a form and not a link. Additionally, Remix will only re-call our loaders when we perform an `action`, so if we used a `loader` then the cache would not get invalidated. The `loader` is just there in case someone somehow lands on that page, we'll just redirect them back home.

```tsx
<Link to="new" className="button">
Expand Down Expand Up @@ -6090,7 +6090,7 @@ I feel pretty great about the user experience we've created here. So let's get t

<docs-error>Note, deploying to fly with a sqlite database is going to cost a little bit of money: A couple bucks per month you have it running.</docs-error>

💿 Before proceeding, you're going to need to to [install fly](https://fly.io/docs/hands-on/installing/) and [sign up for an account](https://fly.io/docs/hands-on/sign-up/).
💿 Before proceeding, you're going to need to [install fly](https://fly.io/docs/hands-on/installing/) and [sign up for an account](https://fly.io/docs/hands-on/sign-up/).

💿 Once you've done that, run this command from within your project directory:

Expand Down