Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @remix-run/node from Vite's optimizeDeps.include #9287

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

markdalgleish
Copy link
Member

@markdalgleish markdalgleish commented Apr 23, 2024

For most consumers this is a no-op but results in Vite warnings when not depending on this package. This was originally added as a workaround for a Playwright test failure in Safari but this is now redundant since we moved to pnpm.

Copy link

changeset-bot bot commented Apr 23, 2024

🦋 Changeset detected

Latest commit: 4a0f48c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@markdalgleish markdalgleish merged commit c53eb7d into dev Apr 24, 2024
9 checks passed
@markdalgleish markdalgleish deleted the markdalgleish/remove-remix-node-from-optimizedeps branch April 24, 2024 03:29
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting release This issue has been fixed and will be released soon CLA Signed package:dev vite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant