fix: jokes tutorial actions should return 400 status for errors #895
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
When a request is sent to the server and there's something invalid about
the request, the server should return a 4xx status to accurately
represent the response.
We could have all the error cases use the
json
function directly, butthen we loose the advantage of the helpful typechecking
ActionData
provides.
For this reason, I've introduced the
badRequest
helper function sothat we can still get typechecking for
ActionFunction
returns, whilereturning the accurate status in the Response.
Reference: https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/400
Notes for the reviewer
I'm pretty sure I've updated all the line highlights correctly, but if you have any way of rendering a preview of the docs, that would help to increase confidence.
Thanks for your time reviewing this! 🙏