Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom Vite build.assetsDir option #8843

Merged
merged 5 commits into from
Feb 25, 2024
Merged

Support custom Vite build.assetsDir option #8843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
733e729
fix: move manifestPath to use vite's assetsDir
ericchernuka Feb 21, 2024
6333878
chore: add ericchernuka contribution.yml
ericchernuka Feb 21, 2024
da74700
Merge branch 'dev' into ec/asset-manifest
markdalgleish Feb 25, 2024
6ea2a38
Add changeset
markdalgleish Feb 25, 2024
6b125cb
Refactor
markdalgleish Feb 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tender-keys-develop.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@remix-run/dev": patch
---

Support custom Vite `build.assetsDir` option
1 change: 1 addition & 0 deletions contributors.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@
- emzoumpo
- enbonnet
- eps1lon
- ericchernuka
- esamattis
- evanwinter
- everdimension
Expand Down
7 changes: 6 additions & 1 deletion packages/remix-dev/vite/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,6 +778,8 @@ export const remixVitePlugin: RemixVitePlugin = (remixUserConfig = {}) => {
remixBrowserManifest: RemixManifest;
remixServerManifest: RemixManifest;
}> => {
invariant(viteConfig);

let viteManifest = await loadViteManifest(
getClientBuildDirectory(ctx.remixConfig)
);
Expand Down Expand Up @@ -833,7 +835,10 @@ export const remixVitePlugin: RemixVitePlugin = (remixUserConfig = {}) => {

let fingerprintedValues = { entry, routes: browserRoutes };
let version = getHash(JSON.stringify(fingerprintedValues), 8);
let manifestPath = `assets/manifest-${version}.js`;
let manifestPath = path.posix.join(
viteConfig.build.assetsDir,
`manifest-${version}.js`
);
let url = `${ctx.remixConfig.publicPath}${manifestPath}`;
let nonFingerprintedValues = { url, version };

Expand Down
Loading