Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remix-dev/vite): modify manifest paths #8599

Merged
merged 9 commits into from
Jan 28, 2024

Conversation

markdalgleish
Copy link
Member

Fixes #8589

Vite manifest files are now moved from the client and server output directories to the new top-level build/.vite directory. Since we're managing these files on disk now, I've also updated the logic so that the Vite manifests are deleted if build.manifest isn't set to true in their Vite config.

For consistency, the Remix build manifest path has been changed to build/.remix/manifest.json.

Copy link

changeset-bot bot commented Jan 25, 2024

🦋 Changeset detected

Latest commit: 8ab4276

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

// ourselves rather than relying on Vite to do it, otherwise you can end up
// with stale server bundle directories in your build output
await cleanServerBuildDirectory(viteConfig, ctx);
await cleanBuildDirectory(viteConfig, ctx);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that manifest files are written to the root of the build directory, the comment that was written here previously now applies more generally to any Remix build since it may result in a different set of manifest files.

@markdalgleish markdalgleish merged commit d1a6579 into dev Jan 28, 2024
9 checks passed
@markdalgleish markdalgleish deleted the markdalgleish/modify-manifest-paths branch January 28, 2024 23:12
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Jan 28, 2024
Copy link
Contributor

🤖 Hello there,

We just published version 2.6.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

github-actions bot commented Feb 1, 2024

🤖 Hello there,

We just published version 2.6.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants