-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(remix-dev/vite): modify manifest paths #8599
Conversation
🦋 Changeset detectedLatest commit: 8ab4276 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
// ourselves rather than relying on Vite to do it, otherwise you can end up | ||
// with stale server bundle directories in your build output | ||
await cleanServerBuildDirectory(viteConfig, ctx); | ||
await cleanBuildDirectory(viteConfig, ctx); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that manifest files are written to the root of the build directory, the comment that was written here previously now applies more generally to any Remix build since it may result in a different set of manifest files.
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
Fixes #8589
Vite manifest files are now moved from the
client
andserver
output directories to the new top-levelbuild/.vite
directory. Since we're managing these files on disk now, I've also updated the logic so that the Vite manifests are deleted ifbuild.manifest
isn't set totrue
in their Vite config.For consistency, the Remix build manifest path has been changed to
build/.remix/manifest.json
.