Unwrap thrown Responses from entry.server into ErrorResponses #8577
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to throw a
Response
fromentry.server
and unwrap it into anErrorResponse
for the second render, as we would do for aloader
/action
-thrown response.It is the responsibility of the user to acoid a second throwing operation since entry.server will run again for the error render. For example:
The use-case prompting this is for apps migrating from Apollo that are doing their data fetch in entry-server instead of loaders.
Note: This will fail CI until we get the associated RR PR into an experimental or prerelease
Sibling RR PR: remix-run/react-router#11213