Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create-remix: high-contrast fg/bg for header colors #8503

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

pcattori
Copy link
Contributor

@pcattori pcattori commented Jan 12, 2024

bgWhite and whiteBright are the same color in many terminal colorthemes, which was causing it to render as illegible white-on-white.

For some reason the done section was already bgWhite/black and was working properly 🤷

BEFORE

Screenshot 2024-01-12 at 1 01 24 PM

AFTER

Screenshot 2024-01-12 at 12 56 56 PM

Copy link

changeset-bot bot commented Jan 12, 2024

🦋 Changeset detected

Latest commit: 979ddef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pcattori pcattori changed the title craete-remix: high-contrast fg/bg for header colors create-remix: high-contrast fg/bg for header colors Jan 12, 2024
`bgWhite` and `whiteBright` are the same color in many terminal colorthemes,
which was causing it to render as illegible white-on-white
@pcattori pcattori force-pushed the pedro/create-remix-header-colors branch from 69dd300 to da4c634 Compare January 12, 2024 18:04
@pcattori pcattori merged commit 00c41a6 into dev Jan 12, 2024
9 checks passed
@pcattori pcattori deleted the pedro/create-remix-header-colors branch January 12, 2024 18:59
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Jan 12, 2024
Copy link
Contributor

🤖 Hello there,

We just published version 2.5.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 2.5.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant