-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(remix-dev/vite): fix unstable file read during handleHotUpdate
#8479
fix(remix-dev/vite): fix unstable file read during handleHotUpdate
#8479
Conversation
🦋 Changeset detectedLatest commit: 61939b3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
handleHotUpdate
handleHotUpdate
handleHotUpdate
handleHotUpdate
handleHotUpdate
handleHotUpdate
handleHotUpdate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this!
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
While debugging #8164, I found that there might be an issue with reading a file during
handleHotUpdate
. https://vitejs.dev/guide/api-plugin.html#handlehotupdate suggests usingread
option to read file content to reduce file change event inconsistency. Let me debug further on this branch.Well, actually the issue might not surface in this branch probably because currently
handleHotUpdate
is affording some time due toresolvePluginConfig
, which is then removed in #8164remix/packages/remix-dev/vite/plugin.ts
Lines 1354 to 1355 in 10196df
Regardless, I'll illustrate the idea in this PR and probably cherry-pick it in #8164.
Testing Strategy
Existing tests should pass + Cherry-pick in #8164 and verify no frakiness