Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix-dev/vite): fix unstable file read during handleHotUpdate #8479

Merged

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Jan 11, 2024

While debugging #8164, I found that there might be an issue with reading a file during handleHotUpdate. https://vitejs.dev/guide/api-plugin.html#handlehotupdate suggests using read option to read file content to reduce file change event inconsistency. Let me debug further on this branch.

Well, actually the issue might not surface in this branch probably because currently handleHotUpdate is affording some time due to resolvePluginConfig, which is then removed in #8164

async handleHotUpdate({ server, file, modules }) {
let pluginConfig = await resolvePluginConfig();

Regardless, I'll illustrate the idea in this PR and probably cherry-pick it in #8164.

Testing Strategy

Existing tests should pass + Cherry-pick in #8164 and verify no frakiness

Copy link

changeset-bot bot commented Jan 11, 2024

🦋 Changeset detected

Latest commit: 61939b3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hi-ogawa hi-ogawa changed the title Fix handle hot update get route metadata fix(vite): fix flaky file reading during handleHotUpdate Jan 11, 2024
@hi-ogawa hi-ogawa changed the title fix(vite): fix flaky file reading during handleHotUpdate fix(vite): fix flaky file read during handleHotUpdate Jan 11, 2024
@hi-ogawa hi-ogawa changed the title fix(vite): fix flaky file read during handleHotUpdate fix(vite): fix unstable file read during handleHotUpdate Jan 11, 2024
@hi-ogawa hi-ogawa marked this pull request as ready for review January 11, 2024 08:39
@hi-ogawa hi-ogawa changed the title fix(vite): fix unstable file read during handleHotUpdate fix(remix-dev/vite): fix unstable file read during handleHotUpdate Jan 11, 2024
Copy link
Member

@markdalgleish markdalgleish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@markdalgleish markdalgleish merged commit 5e15016 into remix-run:dev Jan 11, 2024
9 checks passed
@hi-ogawa hi-ogawa deleted the fix-handleHotUpdate-getRouteMetadata branch January 12, 2024 00:17
Copy link
Contributor

🤖 Hello there,

We just published version 2.5.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 2.5.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants